kgusakov commented on code in PR #3266:
URL: https://github.com/apache/ignite-3/pull/3266#discussion_r1510361555
##########
modules/configuration-api/src/main/java/org/apache/ignite/configuration/ConfigurationModule.java:
##########
@@ -97,7 +97,10 @@ default Collection<Class<?>> polymorphicSchemaExtensions() {
/**
* Patches the provided configuration with dynamic default values. This
method is called
- * only for cluster-wide configuration on cluster initialization.
+ * <ul>
+ * <li>for cluster-wide configuration on cluster initialization.</li>
+ * <li>for node-local configuration on configuration read.</li>
Review Comment:
Changed
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/NodeWithAttributes.java:
##########
@@ -30,11 +31,33 @@ public class NodeWithAttributes implements Serializable {
private final Node node;
- private final Map<String, String> nodeAttributes;
+ private final Map<String, String> userAttributes;
- public NodeWithAttributes(String nodeName, String nodeId, Map<String,
String> nodeAttributes) {
+ private final List<String> storageProfiles;
+
+ /**
+ * Constructor.
+ *
+ * @param nodeName Node name.
+ * @param nodeId Node consistent identifier.
+ * @param userAttributes Key value map of user's node's attributes.
+ */
+ public NodeWithAttributes(String nodeName, String nodeId, Map<String,
String> userAttributes) {
+ this(nodeName, nodeId, userAttributes, List.of());
+ }
+
+ /**
+ * Constructor.
+ *
+ * @param nodeName Node name.
+ * @param nodeId Node consistent identifier.
+ * @param userAttributes Key value map of user's node's attributes.
+ * @param storageProfiles List of supported storage profiles on the node.
+ */
+ public NodeWithAttributes(String nodeName, String nodeId, Map<String,
String> userAttributes, List<String> storageProfiles) {
this.node = new Node(nodeName, nodeId);
- this.nodeAttributes = nodeAttributes;
+ this.userAttributes = userAttributes == null ? Map.of() :
userAttributes;
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
