kgusakov commented on code in PR #3266:
URL: https://github.com/apache/ignite-3/pull/3266#discussion_r1510374005
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/configuration/PageMemoryStorageEngineLocalConfigurationModule.java:
##########
@@ -20,21 +20,23 @@
import com.google.auto.service.AutoService;
import java.util.Collection;
import java.util.List;
-import java.util.Set;
import org.apache.ignite.configuration.ConfigurationModule;
-import org.apache.ignite.configuration.RootKey;
+import org.apache.ignite.configuration.SuperRootChange;
import org.apache.ignite.configuration.annotation.ConfigurationType;
-import org.apache.ignite.configuration.validation.Validator;
-import
org.apache.ignite.internal.storage.pagememory.configuration.schema.PersistentPageMemoryDataStorageConfigurationSchema;
-import
org.apache.ignite.internal.storage.pagememory.configuration.schema.PersistentPageMemoryStorageEngineConfiguration;
-import
org.apache.ignite.internal.storage.pagememory.configuration.schema.VolatilePageMemoryDataStorageConfigurationSchema;
-import
org.apache.ignite.internal.storage.pagememory.configuration.schema.VolatilePageMemoryStorageEngineConfiguration;
+import
org.apache.ignite.internal.pagememory.configuration.schema.PersistentPageMemoryProfileChange;
+import
org.apache.ignite.internal.pagememory.configuration.schema.PersistentPageMemoryProfileConfigurationSchema;
+import
org.apache.ignite.internal.pagememory.configuration.schema.VolatilePageMemoryProfileConfigurationSchema;
+import org.apache.ignite.internal.storage.configurations.StorageConfiguration;
+import
org.apache.ignite.internal.storage.pagememory.configuration.schema.PersistentPageMemoryStorageEngineExtensionConfigurationSchema;
+import
org.apache.ignite.internal.storage.pagememory.configuration.schema.VolatilePageMemoryStorageEngineExtensionConfigurationSchema;
/**
* {@link ConfigurationModule} for cluster-wide configuration provided by
ignite-storage-page-memory.
Review Comment:
Updated
##########
modules/storage-page-memory/src/test/java/org/apache/ignite/internal/storage/pagememory/PersistentPageMemoryMvTableStorageTest.java:
##########
@@ -52,13 +53,16 @@ public class PersistentPageMemoryMvTableStorageTest extends
AbstractMvTableStora
@BeforeEach
void setUp(
@WorkDirectory Path workDir,
- @InjectConfiguration
PersistentPageMemoryStorageEngineConfiguration engineConfig
+ @InjectConfiguration
PersistentPageMemoryStorageEngineConfiguration engineConfig,
+ @InjectConfiguration("mock.profiles.default = {engine =
\"aipersist\"}")
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
