kgusakov commented on code in PR #3266:
URL: https://github.com/apache/ignite-3/pull/3266#discussion_r1510373473
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/ddl/CreateZoneCommand.java:
##########
@@ -114,11 +91,11 @@ public void affinity(String affinity) {
}
@Nullable public String nodeFilter() {
- return nodeFiler;
+ return nodeFilter;
}
public void nodeFilter(String nodeFiler) {
Review Comment:
Fixed
##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/DataStorageManager.java:
##########
@@ -39,21 +35,35 @@ public class DataStorageManager implements IgniteComponent {
/** Mapping: {@link DataStorageModule#name} -> {@link StorageEngine}. */
private final Map<String, StorageEngine> engines;
+ /** Mapping: {@link StorageProfileConfiguration#name()} -> {@link
StorageEngine#name()}. */
+ private Map<String, String> profilesToEngines;
+
+ /** Storage configuration. **/
+ private StorageConfiguration storageConfiguration;
+
/**
* Constructor.
*
* @param engines Storage engines unique by {@link DataStorageModule#name
name}.
+ * @param storageConfiguration Storage configuration. Needed to extract
the storage profiles configurations after start.
*/
- public DataStorageManager(Map<String, StorageEngine> engines) {
+ public DataStorageManager(Map<String, StorageEngine> engines,
StorageConfiguration storageConfiguration) {
assert !engines.isEmpty();
this.engines = engines;
+ this.storageConfiguration = storageConfiguration;
}
@Override
public CompletableFuture<Void> start() throws StorageException {
engines.values().forEach(StorageEngine::start);
+ profilesToEngines = new HashMap<>();
+
+ storageConfiguration.value().profiles().forEach(profile -> {
Review Comment:
Yep, fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
