dant3 opened a new pull request, #3373: URL: https://github.com/apache/ignite-3/pull/3373
This PR inroduces additional static analysis tool: SpotBugs. Some of the problems found was fixed as part of this patch, or suppressed as being false-positives. List of tickets for issues worth checking raised as a result of this work: * [IGNITE-21690](https://issues.apache.org/jira/browse/IGNITE-21690) ConfigurationNode has inconsistent synchronized access to fields `invalid` and `val` * [IGNITE-21691](https://issues.apache.org/jira/browse/IGNITE-21691) BasicMetricExporter has inconsistent synchronized access to field `configuration` * [IGNITE-21693](https://issues.apache.org/jira/browse/IGNITE-21693) TxManagerImpl increments/decrements volatile field `inflights` * [IGNITE-21694](https://issues.apache.org/jira/browse/IGNITE-21694) HeapLockManager/HeapUnboundedLockManager makes inefficient use of keySet iterator instead of entrySet iterator * [IGNITE-21700](https://issues.apache.org/jira/browse/IGNITE-21700) IgniteSort: result of RelOptCost.plus is ignored but it doesn’t have side-effects * [IGNITE-21701](https://issues.apache.org/jira/browse/IGNITE-21701) IgniteSender compares unrelated types * [IGNITE-21695](https://issues.apache.org/jira/browse/IGNITE-21695) PageHandler: useless control flow * [IGNITE-21699](https://issues.apache.org/jira/browse/IGNITE-21699) DistributionFunction compares strings by reference * [IGNITE-21702](https://issues.apache.org/jira/browse/IGNITE-21702) AbstractNode field `inBufSize` is unused * [IGNITE-21703](https://issues.apache.org/jira/browse/IGNITE-21703) IgniteSqlFunctions.octetLength relies on default encoding * [IGNITE-21704](https://issues.apache.org/jira/browse/IGNITE-21704) ConfigurationListenerHolder uses weird equals implementation * [IGNITE-21705](https://issues.apache.org/jira/browse/IGNITE-21705) CheckpointWorkflow uses weird equals implementation * [IGNITE-21706](https://issues.apache.org/jira/browse/IGNITE-21706) RandomLruPageReplacementPolicy has dead conditions * [IGNITE-21692](https://issues.apache.org/jira/browse/IGNITE-21692) AbstractFreeList has unused private method `initReusedPage` * [IGNITE-21696](https://issues.apache.org/jira/browse/IGNITE-21696) LazyStripedExecutor performs synchronization on AtomicReferenceArray * [IGNITE-21697](https://issues.apache.org/jira/browse/IGNITE-21697) ConnectionManager ignores exceptional return value of ExecutorService.submit * [IGNITE-21698](https://issues.apache.org/jira/browse/IGNITE-21698) LocalConfigurationStorage reboxes unboxed value Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following: ### The Review Checklist - [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. Also make sure to complete the following: \- There is a single JIRA ticket related to the pull request. \- The web-link to the pull request is attached to the JIRA ticket. \- The JIRA ticket has the Patch Available state. \- The description of the JIRA ticket explains WHAT was made, WHY and HOW. \- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue. - [ ] **Design:** new code conforms with the design principles of the components it is added to. - [ ] **Patch quality:** patch cannot be split into smaller pieces, its size must be reasonable. - [ ] **Code quality:** code is clean and readable, necessary developer documentation is added if needed. - [ ] **Tests code quality:** test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources. ### Notes - [Apache Ignite Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
