tkalkirill commented on code in PR #3373:
URL: https://github.com/apache/ignite-3/pull/3373#discussion_r1515927928
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/Checkpointer.java:
##########
@@ -634,10 +634,9 @@ public void cancel() {
log.debug("Cancelling grid runnable: " + this);
}
- // Do not interrupt runner thread.
- isCancelled.set(true);
-
synchronized (this) {
+ // Do not interrupt runner thread.
+ isCancelled.set(true);
Review Comment:
You need to return it back, taking the monitor may take longer than it seems
at first glance, and `isCancelled` is also read without a monitor.
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PersistentPageMemory.java:
##########
@@ -519,9 +519,9 @@ public long allocatePage(int grpId, int partId, byte flags)
throws IgniteInterna
seg.writeLock().lock();
- FullPageId fullId = new FullPageId(pageId, grpId);
try {
+ FullPageId fullId = new FullPageId(pageId, grpId);
Review Comment:
```suggestion
FullPageId fullId = new FullPageId(pageId, grpId);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
