alievmirza commented on code in PR #3373:
URL: https://github.com/apache/ignite-3/pull/3373#discussion_r1515876279
##########
modules/core/src/main/java/org/apache/ignite/internal/util/OffheapReadWriteLock.java:
##########
@@ -346,7 +347,7 @@ private void signalNextWaiter(int writeWaitCnt, int idx) {
* the write lock without leaving a gap. Returns {@code false}
otherwise, in this case the resource
* state must be re-validated.
*/
- public Boolean upgradeToWriteLock(long lock, int tag) {
+ public @Nullable Boolean upgradeToWriteLock(long lock, int tag) {
Review Comment:
Hm, I've looked a bit closer and it's true that this method can return
`null` as a valid outcome, so my comment is incorrect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
