sashapolo commented on code in PR #3488:
URL: https://github.com/apache/ignite-3/pull/3488#discussion_r1540630790
##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/Index.java:
##########
@@ -74,7 +76,7 @@ final void close() {
try {
IgniteUtils.closeAll(storageByPartitionId.values().stream().map(index ->
index::close));
} catch (Exception e) {
- throw new StorageException("Failed to close index storages: " +
indexId, e);
+ throw new StorageException("Failed to close index storages: " +
indexColumnFamily.indexId(), e);
Review Comment:
> U can use ...
yes, but what's the point? The current code is already quite laconic
> Maybe create method Index#id() to simplify?
To simplify what? `indexColumnFamily.indexId()`? It's not used that often
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
