sashapolo commented on code in PR #3488:
URL: https://github.com/apache/ignite-3/pull/3488#discussion_r1540639144
##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbStorageEngine.java:
##########
@@ -125,40 +137,49 @@ public String name() {
@Override
public void start() throws StorageException {
- registerDataRegion(DEFAULT_DATA_REGION_NAME);
+ registerDataRegion(engineConfig.defaultRegion().value());
// TODO: IGNITE-17066 Add handling deleting/updating data regions
configuration
engineConfig.regions().listenElements(new
ConfigurationNamedListListener<>() {
@Override
public CompletableFuture<?>
onCreate(ConfigurationNotificationEvent<RocksDbDataRegionView> ctx) {
- registerDataRegion(ctx.newName(RocksDbDataRegionView.class));
+ RocksDbDataRegionView newValue = ctx.newValue();
+
+ assert newValue != null;
Review Comment:
This is mostly because IDEA's nullability warning is triggered, I prefer to
suppress it using an assertion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
