sashapolo commented on code in PR #3488:
URL: https://github.com/apache/ignite-3/pull/3488#discussion_r1540637643
##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbDataRegion.java:
##########
@@ -47,33 +46,31 @@ public class RocksDbDataRegion {
*
* @param cfg Data region configuration.
*/
- public RocksDbDataRegion(RocksDbDataRegionConfiguration cfg) {
+ public RocksDbDataRegion(RocksDbDataRegionView cfg) {
this.cfg = cfg;
}
/**
* Start the rocksDb data region.
*/
public void start() {
- RocksDbDataRegionView dataRegionView = cfg.value();
+ long writeBufferSize = cfg.writeBufferSize();
- long writeBufferSize = dataRegionView.writeBufferSize();
+ long totalCacheSize = cfg.size() + writeBufferSize;
- long totalCacheSize = dataRegionView.size() + writeBufferSize;
-
- switch (dataRegionView.cache().toLowerCase(Locale.ROOT)) {
+ switch (cfg.cache().toLowerCase(Locale.ROOT)) {
case ROCKSDB_CLOCK_CACHE:
- cache = new ClockCache(totalCacheSize,
dataRegionView.numShardBits(), false);
+ cache = new ClockCache(totalCacheSize, cfg.numShardBits(),
false);
break;
case ROCKSDB_LRU_CACHE:
- cache = new LRUCache(totalCacheSize,
dataRegionView.numShardBits(), false);
+ cache = new LRUCache(totalCacheSize, cfg.numShardBits(),
false);
break;
default:
- assert false : dataRegionView.cache();
+ assert false : cfg.cache();
Review Comment:
fixed
##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbDataRegion.java:
##########
@@ -34,7 +33,7 @@
*/
public class RocksDbDataRegion {
/** Region configuration. */
- private final RocksDbDataRegionConfiguration cfg;
+ private final RocksDbDataRegionView cfg;
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
