sanpwc commented on code in PR #3548:
URL: https://github.com/apache/ignite-3/pull/3548#discussion_r1559329974
##########
modules/index/src/test/java/org/apache/ignite/internal/index/ChangeIndexStatusTaskControllerTest.java:
##########
@@ -188,11 +189,13 @@ private void setPrimaryReplicaAnotherNode() {
}
private void setPrimaryReplica(ClusterNode clusterNode) {
- TablePartitionId groupId = new TablePartitionId(tableId(), 0);
+ ZonePartitionId zonePartId = new ZonePartitionId(0, 0, tableId());
Review Comment:
Here and there. Using 0 is generally not consistent. `tableId` internally
wil retrieve id from CatalogTableDescriptor
```
public static CatalogTableDescriptor getTableStrict(CatalogService
catalogService, String tableName, long timestamp) {
CatalogTableDescriptor table = catalogService.table(tableName,
timestamp);
assertNotNull(table, "tableName=" + tableName + ", timestamp=" +
timestamp);
return table;
}
```
Meaning that we should retrieve zoneId from the same descriptor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
