sanpwc commented on code in PR #3548:
URL: https://github.com/apache/ignite-3/pull/3548#discussion_r1559340545
##########
modules/placement-driver-api/src/main/java/org/apache/ignite/internal/placementdriver/PlacementDriver.java:
##########
@@ -60,6 +61,28 @@ CompletableFuture<ReplicaMeta> awaitPrimaryReplica(
TimeUnit unit
);
+ /**
+ * Temporary solution for awaiting {@link ReplicaMeta}. Waits for
+ * {@link ReplicaMeta} for {@link
org.apache.ignite.internal.replicator.TablePartitionId}
+ * based on the {@link ZonePartitionId#tableId()}.
+ *
+ * @param groupId Replication group id.
+ * @param timestamp CLOCK_SKEW aware timestamp reference value.
+ * @param timeout How long to wait before completing exceptionally with a
TimeoutException, in units of unit.
+ * @param unit A TimeUnit determining how to interpret the timeout
parameter.
+ * @return Primary replica future.
+ * @throws PrimaryReplicaAwaitTimeoutException If primary replica await
timed out.
+ * @throws PrimaryReplicaAwaitException If primary replica await failed
with any other reason except timeout.
+ */
+ default CompletableFuture<ReplicaMeta> awaitPrimaryReplicaForTable(
+ ZonePartitionId groupId,
Review Comment:
Why it's `ZonePartitionId`? It should be `ReplicationGroupId`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
