sanpwc commented on code in PR #3548:
URL: https://github.com/apache/ignite-3/pull/3548#discussion_r1559331869
##########
modules/index/src/test/java/org/apache/ignite/internal/index/ChangeIndexStatusTaskControllerTest.java:
##########
@@ -188,11 +189,13 @@ private void setPrimaryReplicaAnotherNode() {
}
private void setPrimaryReplica(ClusterNode clusterNode) {
- TablePartitionId groupId = new TablePartitionId(tableId(), 0);
+ ZonePartitionId zonePartId = new ZonePartitionId(0, 0, tableId());
- ReplicaMeta replicaMeta = newPrimaryReplicaMeta(clusterNode, groupId,
HybridTimestamp.MIN_VALUE, HybridTimestamp.MAX_VALUE);
+ TablePartitionId tablePartId = new TablePartitionId(tableId(), 0);
- assertThat(placementDriver.setPrimaryReplicaMeta(0, groupId,
completedFuture(replicaMeta)), willCompleteSuccessfully());
+ ReplicaMeta replicaMeta = newPrimaryReplicaMeta(clusterNode,
tablePartId, HybridTimestamp.MIN_VALUE, HybridTimestamp.MAX_VALUE);
Review Comment:
Why it's tablePartId in replicaMeta? We should have new ZonePartitionId
there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
