tkalkirill commented on code in PR #3589:
URL: https://github.com/apache/ignite-3/pull/3589#discussion_r1561091997
##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/index/StorageSortedIndexDescriptor.java:
##########
@@ -99,34 +95,30 @@ public String toString() {
private final BinaryTupleSchema binaryTupleSchema;
+ private final boolean pk;
+
/**
* Constructor.
*
* @param table Catalog table descriptor.
* @param index Catalog index descriptor.
*/
public StorageSortedIndexDescriptor(CatalogTableDescriptor table,
CatalogSortedIndexDescriptor index) {
- this(index.id(), extractIndexColumnsConfiguration(table, index));
+ this(index.id(), extractIndexColumnsConfiguration(table, index),
table.primaryKeyIndexId() == index.id());
}
/**
* Creates an Index Descriptor from a given set of column descriptors.
*
* @param indexId Index ID.
* @param columnDescriptors Column descriptors.
+ * @param pk Primary index flag.
*/
- public StorageSortedIndexDescriptor(int indexId,
List<StorageSortedIndexColumnDescriptor> columnDescriptors) {
+ public StorageSortedIndexDescriptor(int indexId,
List<StorageSortedIndexColumnDescriptor> columnDescriptors, boolean pk) {
Review Comment:
It is also used in product code, please see usages.
Please give an example of how you could implement your idea in those places
where I use this internal flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
