tkalkirill commented on code in PR #3589:
URL: https://github.com/apache/ignite-3/pull/3589#discussion_r1561098704
##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/index/StorageSortedIndexDescriptor.java:
##########
@@ -150,20 +145,28 @@ private static List<StorageSortedIndexColumnDescriptor>
extractIndexColumnsConfi
CatalogTableDescriptor table,
CatalogSortedIndexDescriptor index
) {
- assert table.id() == index.tableId() : "tableId=" + table.id() + ",
indexTableId=" + index.tableId();
+ assert table.id() == index.tableId() : "indexId=" + index.id() + ",
tableId=" + table.id() + ", indexTableId=" + index.tableId();
return index.columns().stream()
.map(columnDescriptor -> {
String columnName = columnDescriptor.name();
CatalogTableColumnDescriptor column =
table.column(columnName);
- assert column != null : columnName;
+ assert column != null : "indexId=" + index.id() + ",
columnName=" + columnName;
CatalogColumnCollation collation =
columnDescriptor.collation();
return new StorageSortedIndexColumnDescriptor(columnName,
getNativeType(column), column.nullable(), collation.asc());
})
.collect(toList());
}
+
+ private static BinaryTupleSchema
createSchema(List<StorageSortedIndexColumnDescriptor> columns) {
Review Comment:
For me it looks more convenient that the internal methods are located below,
I can return this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
