tkalkirill commented on code in PR #3589:
URL: https://github.com/apache/ignite-3/pull/3589#discussion_r1561093961
##########
modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/AbstractMvTableStorageTest.java:
##########
@@ -123,25 +126,24 @@ public abstract class AbstractMvTableStorageTest extends
BaseMvStoragesTest {
protected StorageHashIndexDescriptor hashIdx;
+ protected StorageIndexDescriptor pkIdx;
+
private final CatalogService catalogService = mock(CatalogService.class);
- protected final StorageIndexDescriptorSupplier indexDescriptorSupplier =
new StorageIndexDescriptorSupplier() {
- @Override
- public @Nullable StorageIndexDescriptor get(int indexId) {
- int catalogVersion = catalogService.latestCatalogVersion();
+ protected final StorageIndexDescriptorSupplier indexDescriptorSupplier =
indexId -> {
Review Comment:
I don't see anything wrong with this and it's not prohibited.
##########
modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/index/AbstractIndexStorageTest.java:
##########
@@ -79,9 +85,11 @@ public abstract class AbstractIndexStorageTest<S extends
IndexStorage, D extends
protected static final int TEST_PARTITION = 12;
- protected static final String INDEX_NAME = "TEST_IDX";
+ protected static final String TABLE_NAME = "FOO";
+
+ protected static final String PK_INDEX_NAME = pkIndexName(TABLE_NAME);
- protected static final String TABLE_NAME = "foo";
+ protected static final String INDEX_NAME = "TEST_IDX";
Review Comment:
I don't see anything wrong with this and it's not prohibited.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
