ibessonov commented on code in PR #3589:
URL: https://github.com/apache/ignite-3/pull/3589#discussion_r1562134395
##########
modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/AbstractMvTableStorageTest.java:
##########
@@ -123,25 +126,24 @@ public abstract class AbstractMvTableStorageTest extends
BaseMvStoragesTest {
protected StorageHashIndexDescriptor hashIdx;
+ protected StorageIndexDescriptor pkIdx;
+
private final CatalogService catalogService = mock(CatalogService.class);
- protected final StorageIndexDescriptorSupplier indexDescriptorSupplier =
new StorageIndexDescriptorSupplier() {
- @Override
- public @Nullable StorageIndexDescriptor get(int indexId) {
- int catalogVersion = catalogService.latestCatalogVersion();
+ protected final StorageIndexDescriptorSupplier indexDescriptorSupplier =
indexId -> {
Review Comment:
Generally speaking, I'm against changing the code that's already good
enough. And if we really want to do so, it's better to be done centralized.
That anonymous class wasn't bad. Few lines of extra code are not a real
issue. So I conclude that you just wanted to change something because it didn't
look like you wanted it to look, instead of thinking "does it really look
inappropriate to the point of re-writing it?". I don't like useless changes in
code. They bloat your pull requests, artificially increasing their sizes. They
don't really contribute to the quality of the product - code doesn't become
better.
_We should concentrate our efforts on real issues, instead of changing the
code that's already good._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
