tkalkirill commented on code in PR #3589:
URL: https://github.com/apache/ignite-3/pull/3589#discussion_r1562169208
##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/index/StorageHashIndexDescriptor.java:
##########
@@ -112,17 +114,22 @@ public List<StorageHashIndexColumnDescriptor> columns() {
return columns;
}
+ @Override
+ public boolean isPk() {
Review Comment:
> Let's leave it, with hopes that we will change it in the future.
Nice.
> We can make them atomic, what's the issue?
Yes, in general, we can, but so far in my head it looks better, plus writing
tests in different places is not centralized.
> same applies to your code
Maybe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
