tkalkirill commented on code in PR #3589:
URL: https://github.com/apache/ignite-3/pull/3589#discussion_r1562035068
##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/index/StorageHashIndexDescriptor.java:
##########
@@ -112,17 +114,22 @@ public List<StorageHashIndexColumnDescriptor> columns() {
return columns;
}
+ @Override
+ public boolean isPk() {
Review Comment:
What problems do I see in your campaign:
1) We need to remember that for the primary index we need to reset field
`nextRowIdToBuild`, which may be forgotten after some time.
2) Performing these two operations is not atomic, it can lead to unpleasant
consequences in the product code for users; the first thing that comes to mind
is that the server will be pulled out of the socket immediately after the
creation of the index storage is completed. Then we will need to add the
correct recovery procedure somewhere else.
I don’t claim that my solution is ideal, I don’t really like it myself, but
it looks more correct at the moment, I suggest leaving it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
