denis-chudov commented on code in PR #3591:
URL: https://github.com/apache/ignite-3/pull/3591#discussion_r1570173136
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/VolatileTxStateMetaStorage.java:
##########
@@ -155,14 +187,62 @@ public void vacuum(long vacuumObservationTimestamp, long
txnResourceTtl) {
});
});
- LOG.info("Vacuum finished [vacuumObservationTimestamp={},
txnResourceTtl={}, vacuumizedTxnsCount={},"
- + " markedAsInitiallyDetectedTxnsCount={},
alreadyMarkedTxnsCount={}, skippedFotFurtherProcessingUnfinishedTxnsCount={}].",
- vacuumObservationTimestamp,
- txnResourceTtl,
- vacuumizedTxnsCount,
- markedAsInitiallyDetectedTxnsCount,
- alreadyMarkedTxnsCount,
- skippedFotFurtherProcessingUnfinishedTxnsCount
+ beforeVacuum.apply(txIds)
+ .thenAccept(tuple -> {
Review Comment:
kinda tricky, and we will have to pass the timestamps map to the persistent
vacuum operation in order to compare the timestamps. Also, we'd better to have
to count of successful persistent vacuums in log, so we cant just skip this
future.
But I slightly revorked this part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
