sanpwc commented on code in PR #3591:
URL: https://github.com/apache/ignite-3/pull/3591#discussion_r1572498142
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java:
##########
@@ -406,18 +413,18 @@ private UpdateCommandResult
handleUpdateAllCommand(UpdateAllCommand cmd, long co
* Handler for the {@link WriteIntentSwitchCommand}.
*
* @param cmd Command.
- * @param commandIndex Index of the RAFT command.
- * @param commandTerm Term of the RAFT command.
+ * @param commandIndex Index of the RAFT cmd.
+ * @param commandTerm Term of the RAFT cmd.
*/
private void handleWriteIntentSwitchCommand(WriteIntentSwitchCommand cmd,
long commandIndex, long commandTerm) {
- // Skips the write command because the storage has already executed it.
+ // Skips the write cmd because the storage has already executed it.
if (commandIndex <= storage.lastAppliedIndex()) {
return;
}
UUID txId = cmd.txId();
- markFinished(txId, cmd.commit(), cmd.commitTimestamp());
+ markFinished(txId, cmd.commit(), cmd.commitTimestamp(), null);
Review Comment:
And why we need it to be present on all nodes of commit partition?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
