sanpwc commented on code in PR #3591:
URL: https://github.com/apache/ignite-3/pull/3591#discussion_r1575066409
##########
modules/runner/src/testFixtures/java/org/apache/ignite/internal/table/NodeUtils.java:
##########
@@ -49,16 +50,16 @@ public class NodeUtils {
*
* @param nodes Nodes collection.
* @param groupId Group id.
- * @param preferablePrimary Primary replica name which is preferred for
being primary or {@code null}.
+ * @param preferablePrimaryFilter Primary replica preferable nodes filter,
accepts the node consistent id.
* @return New primary replica name.
* @throws InterruptedException If failed.
*/
public static String transferPrimary(
Collection<IgniteImpl> nodes,
ReplicationGroupId groupId,
- @Nullable String preferablePrimary
+ @Nullable Predicate<String> preferablePrimaryFilter
Review Comment:
Is it all about ::contains support? Don't you think that it's a bit too
complicated?
Anyway, I'd definitely preserve original method as sugar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
