xtern commented on code in PR #3626:
URL: https://github.com/apache/ignite-3/pull/3626#discussion_r1572295214
##########
modules/api/src/main/java/org/apache/ignite/sql/Statement.java:
##########
@@ -140,16 +113,22 @@ interface StatementBuilder {
*/
StatementBuilder pageSize(int pageSize);
- /** Returns a statement time zone. */
- ZoneId timeZoneId();
-
/**
* Sets a time zone for this statement.
*
- * @param timeZoneId Time zone ID.
+ * <p>This time zone is used in the following cases:
+ * <ol>
+ * <li>When using SQL functions to obtain the current time (for
example {@code SELECT CURRENT_TIME})</li>
+ * <li>When converting a string literal to/from a TIMESTAMP WITH
LOCAL TIME ZONE column
+ * (for example {@code SELECT TIMESTAMP WITH LOCAL TIME ZONE
'1992-01-18 02:30:00.123'}</li>
+ * </ol>
+ *
+ * <p>If the time zone has not been set explicitly, the current JVM
default time zone will be used.
+ *
+ * @param timeZone Time zone.
* @return {@code this} for chaining.
*/
- StatementBuilder timeZoneId(ZoneId timeZoneId);
+ StatementBuilder timeZone(ZoneId timeZone);
Review Comment:
Renamed it back, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
