xtern commented on code in PR #3626:
URL: https://github.com/apache/ignite-3/pull/3626#discussion_r1574704985
##########
modules/api/src/main/java/org/apache/ignite/sql/Statement.java:
##########
@@ -125,13 +105,6 @@ interface StatementBuilder {
*/
StatementBuilder defaultSchema(String schema);
- /**
- * Returns a page size - the maximum number of result rows that can be
fetched at a time.
- *
- * @return Maximum number of rows per page.
- */
- int pageSize();
-
/**
* Sets a page size - the maximum number of result rows that can be
fetched at a time.
Review Comment:
thanks, javadoc extended.
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItSqlClientMetricsTest.java:
##########
@@ -119,10 +118,10 @@ public void testErroneousFlow() throws Exception {
}
private void assertMetricValue(MetricSet metricSet, String metricName,
Object expectedValue) throws InterruptedException {
- assertTrue(
- waitForCondition(
- () ->
expectedValue.toString().equals(metricSet.get(metricName).getValueAsString()),
- 1000)
- );
+ waitForCondition(
+ () ->
expectedValue.toString().equals(metricSet.get(metricName).getValueAsString()),
+ 1000);
+
+ assertEquals(expectedValue.toString(),
metricSet.get(metricName).getValueAsString());
Review Comment:
done, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
