Re: [PR] IGNITE-18647 Sql. Implement missed Statement and StatementBuilder methods. [ignite-3]

[via GitHub]

xtern commented on code in PR #3626:
URL: https://github.com/apache/ignite-3/pull/3626#discussion_r1574688833


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/api/IgniteSqlImpl.java:
##########
@@ -327,11 +322,12 @@ public <T> CompletableFuture<AsyncResultSet<T>> 
executeAsync(
 
     private CompletableFuture<AsyncResultSet<SqlRow>> executeAsyncInternal(
             @Nullable Transaction transaction,
-            String query,
-            int pageSize,
+            Statement statement,
             @Nullable Object... arguments
     ) {
-        assert pageSize > 0 : pageSize;
+        assert statement.pageSize() >= 0 : statement.pageSize();

Review Comment:
   > Maybe It is better to make it impossible to create invalid statement
   Thanks, it's impossible now. 
   Validation is done in `StatementImpl`.
   I just kept assertion that pageSize is positive here.



##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/api/IgniteSqlImpl.java:
##########
@@ -327,11 +322,12 @@ public <T> CompletableFuture<AsyncResultSet<T>> 
executeAsync(
 
     private CompletableFuture<AsyncResultSet<SqlRow>> executeAsyncInternal(
             @Nullable Transaction transaction,
-            String query,
-            int pageSize,
+            Statement statement,
             @Nullable Object... arguments
     ) {
-        assert pageSize > 0 : pageSize;
+        assert statement.pageSize() >= 0 : statement.pageSize();

Review Comment:
   > Maybe It is better to make it impossible to create invalid statement
   
   Thanks, it's impossible now. 
   Validation is done in `StatementImpl`.
   I just kept assertion that pageSize is positive here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org