Vladsz83 commented on code in PR #11327:
URL: https://github.com/apache/ignite/pull/11327#discussion_r1579570675
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##########
@@ -7287,10 +7287,18 @@ private InetSocketAddress
checkConnection(List<InetSocketAddress> addrs, int tim
sock.connect(addr, perAddrTimeout);
liveAddrHolder.compareAndSet(null, addr);
+
+ if (log.isInfoEnabled())
+ log.info("Successful connection to the
server [address=" + addr + "]");
+ }
+ else if (log.isInfoEnabled()) {
+ log.info("Connection to the server
[address=" + addr + "] is ignored. " +
Review Comment:
Why we log here? We do not connect to a node. Just checking whether it is
alive. We duplicate fuhrter message:
`if (log.isInfoEnabled()) {
log.info("Connection check to previous
node done: [liveAddr=" + liveAddr
+ ", previousNode=" +
U.toShortString(previous) + ", addressesToCheck=" +
nodeAddrs + ", connectingNodeId=" +
nodeId + ']');
}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
