maksaska commented on code in PR #11327:
URL: https://github.com/apache/ignite/pull/11327#discussion_r1580681985
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##########
@@ -7287,10 +7287,18 @@ private InetSocketAddress
checkConnection(List<InetSocketAddress> addrs, int tim
sock.connect(addr, perAddrTimeout);
liveAddrHolder.compareAndSet(null, addr);
+
Review Comment:
You're right! There is no need for such excessive logging. I removed it
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##########
@@ -7287,10 +7287,18 @@ private InetSocketAddress
checkConnection(List<InetSocketAddress> addrs, int tim
sock.connect(addr, perAddrTimeout);
liveAddrHolder.compareAndSet(null, addr);
+
+ if (log.isInfoEnabled())
+ log.info("Successful connection to the
server [address=" + addr + "]");
+ }
+ else if (log.isInfoEnabled()) {
+ log.info("Connection to the server
[address=" + addr + "] is ignored. " +
+ "Alive address is found at [address="
+ liveAddrHolder.get() + "]");
}
}
catch (Exception ignored) {
- // No-op.
+ U.warn(log, "Failed to connect the socket to
the server [address=" + addr +
Review Comment:
I guess WARN is redundant. We just want to see the reason, why the
connection failed. I switched it to log.info(...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
