Vladsz83 commented on code in PR #11327:
URL: https://github.com/apache/ignite/pull/11327#discussion_r1580718592
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java:
##########
@@ -7287,10 +7287,18 @@ private InetSocketAddress
checkConnection(List<InetSocketAddress> addrs, int tim
sock.connect(addr, perAddrTimeout);
liveAddrHolder.compareAndSet(null, addr);
+
+ if (log.isInfoEnabled())
+ log.info("Successful connection to the
server [address=" + addr + "]");
+ }
+ else if (log.isInfoEnabled()) {
+ log.info("Connection to the server
[address=" + addr + "] is ignored. " +
+ "Alive address is found at [address="
+ liveAddrHolder.get() + "]");
}
}
catch (Exception ignored) {
- // No-op.
+ U.warn(log, "Failed to connect the socket to
the server [address=" + addr +
Review Comment:
` log.info("Connection check to previous node done: [liveAddr=" + liveAddr
+ ", previousNode=" +
U.toShortString(previous) + ", addressesToCheck=" +
nodeAddrs + ", connectingNodeId=" +
nodeId + ']');` is not enough? Let's fix it here. `checkConnection` is an
utility method. It doesn't make any decision. It could contain DEBUGs I think.
If we failed to ping previous node, let's say abount it around here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
