JAkutenshi commented on code in PR #3633:
URL: https://github.com/apache/ignite-3/pull/3633#discussion_r1618693640
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -1857,9 +1776,8 @@ private CompletableFuture<Void>
handleChangePendingAssignmentEvent(
boolean isRecovery
) {
ClusterNode localMember = localNode();
- RaftNodeId raftNodeId = new RaftNodeId(replicaGrpId, new
Peer(localNode().name()));
- boolean pendingAssignmentsAreForced = pendingAssignments.force();
+ boolean pendingAssignmentsAreForced = pendingAssignments != null &&
pendingAssignments.force();
Review Comment:
Looks like I'm wrong here or it's last from my attempts to generalize this:
```java
if (pendingAssignmentsAreForced &&
replicaMgr.isReplicaStarted(replicaGrpId)) {
replicaMgr.resetPeers(replicaGrpId,
configurationFromAssignments(nonStableNodeAssignmentsFinal.nodes()));
}
```
btw, I'm removing it, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
