sanpwc commented on code in PR #3633:
URL: https://github.com/apache/ignite-3/pull/3633#discussion_r1620752876
##########
modules/replicator/build.gradle:
##########
@@ -29,6 +29,9 @@ dependencies {
implementation project(':ignite-core')
implementation project(':ignite-raft')
implementation project(':ignite-raft-api')
+ implementation project(':ignite-metastorage-api')
Review Comment:
That seems incorrect. Replicator module is a generic abstraction that might
be implemented by partition replicas or meta storage ones, thus it should not
depend on neither metastorage-api nor distribution-zones nor storage-api. Not
sure about latter one though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
