JAkutenshi commented on code in PR #3633:
URL: https://github.com/apache/ignite-3/pull/3633#discussion_r1618730784
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java:
##########
@@ -620,7 +830,15 @@ private CompletableFuture<Boolean>
stopReplicaInternal(ReplicationGroupId replic
}
});
- return isRemovedFuture;
+ return isRemovedFuture
+ .thenApply(v -> {
+ try {
+ raftManager.stopRaftNodes(replicaGrpId);
Review Comment:
This method `stopRaftNodes` is `raftManager` specific. `RaftManager` is
responsible for nodes' starting and stopping => we're starting them in
`ReplicaManager` => we should stop them in `ReplicaManager` too with
`RaftManager` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
