sanpwc commented on code in PR #4043:
URL: https://github.com/apache/ignite-3/pull/4043#discussion_r1665795506
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java:
##########
@@ -192,6 +202,18 @@ public CompletableFuture<Void> startAsync(ComponentContext
componentContext) {
return nullCompletedFuture();
}
+ CompletableFuture<Long> recoveryFinishFuture =
metaStorageMgr.recoveryFinishedFuture();
+
+ assert recoveryFinishFuture.isDone();
+
+ long recoveryRevision = recoveryFinishFuture.join();
+
+ cleanUpResourcesForDroppedZonesOnRecovery();
+
+ CompletableFuture<Void> processZonesOnStart =
processZonesOnStart(recoveryRevision, lowWatermark.getLowWatermark());
+
+ CompletableFuture<Void> processAssignmentsFuture =
processAssignmentsOnRecovery(recoveryRevision);
Review Comment:
Is it intended not to chain processAssignmentsOnRecovery with
processZonesOnStart?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
