lowka commented on code in PR #4044: URL: https://github.com/apache/ignite-3/pull/4044#discussion_r1668426673
########## modules/sql-engine/src/integrationTest/sql/aggregate/group/test_group_by_distinct.test: ########## @@ -29,20 +29,20 @@ SELECT val FROM integers GROUP BY ALL GROUPING SETS ((val), (val)) 4 query R rowsort -SELECT val FROM ( VALUES (1), (1.0::REAL), (1.0::REAL), (2::DOUBLE), (1.1::REAL), (2::DECIMAL(2)) ) t(val) GROUP BY ALL GROUPING SETS ((val), (val)) Review Comment: `1.1` does not have the exact representation as a double (we get `1.100000023841858`) , use `1.5` instead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
