lowka commented on code in PR #4044:
URL: https://github.com/apache/ignite-3/pull/4044#discussion_r1668458915
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/RexToLixTranslator.java:
##########
@@ -912,7 +913,7 @@ public static Expression translateLiteral(
final Primitive primitive = Primitive.ofBoxOr(javaClass);
final Comparable value = literal.getValueAs(Comparable.class);
if (primitive != null && value instanceof Number) {
- value2 = primitive.number((Number) value);
+ value2 = Primitives.convertPrimitiveExact(primitive,
(Number) value);
Review Comment:
Primitive::number does not perform overchecks for Float/Double .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
