lowka commented on code in PR #4044:
URL: https://github.com/apache/ignite-3/pull/4044#discussion_r1668690515
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/RexUtils.java:
##########
@@ -114,14 +114,14 @@ public class RexUtils {
/** Hash index permitted search operations. */
private static final EnumSet<SqlKind> HASH_SEARCH_OPS = EnumSet.of(EQUALS,
IS_NOT_DISTINCT_FROM);
- private static final BigDecimal MIN_DOUBLE_VALUE =
BigDecimal.valueOf(Double.MIN_VALUE);
-
private static final BigDecimal MAX_DOUBLE_VALUE =
BigDecimal.valueOf(Double.MAX_VALUE);
- private static final BigDecimal MIN_FLOAT_VALUE =
BigDecimal.valueOf(Float.MIN_VALUE);
+ private static final BigDecimal MIN_DOUBLE_VALUE =
MAX_DOUBLE_VALUE.negate();
private static final BigDecimal MAX_FLOAT_VALUE =
BigDecimal.valueOf(Float.MAX_VALUE);
+ private static final BigDecimal MIN_FLOAT_VALUE = MAX_FLOAT_VALUE.negate();
Review Comment:
Float.MIN_VALUE/Double.MIN_VALUE are not minimum values for those types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
