xtern commented on code in PR #4137:
URL: https://github.com/apache/ignite-3/pull/4137#discussion_r1698725717
##########
modules/catalog-compaction/src/main/java/org/apache/ignite/internal/catalog/compaction/CatalogCompactionRunner.java:
##########
@@ -198,115 +225,127 @@ public CompletableFuture<Boolean>
onLowWatermarkChanged(HybridTimestamp newLowWa
}
@TestOnly
- CompletableFuture<Boolean> lastRunFuture() {
+ synchronized CompletableFuture<Void> lastRunFuture() {
return lastRunFuture;
}
/** Starts the catalog compaction routine. */
- CompletableFuture<Boolean> triggerCompaction(@Nullable HybridTimestamp
lwm) {
+ void triggerCompaction(@Nullable HybridTimestamp lwm) {
if (lwm == null ||
!localNodeName.equals(compactionCoordinatorNodeName)) {
- return CompletableFutures.falseCompletedFuture();
+ return;
}
- return inBusyLock(busyLock, () -> {
- CompletableFuture<Boolean> fut = lastRunFuture;
+ inBusyLock(busyLock, () -> {
+ synchronized (this) {
+ CompletableFuture<Void> fut = lastRunFuture;
- if (!fut.isDone()) {
- LOG.info("Catalog compaction is already in progress, skipping
(timestamp={})", lwm.longValue());
+ if (!fut.isDone()) {
+ LOG.info("Catalog compaction is already in progress,
skipping (timestamp={})", lwm.longValue());
Review Comment:
Thanks, fixed.
Added test case for this .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
