xtern commented on code in PR #4137:
URL: https://github.com/apache/ignite-3/pull/4137#discussion_r1698727936
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogManagerImpl.java:
##########
@@ -342,17 +342,26 @@ public CompletableFuture<Integer>
execute(List<CatalogCommand> commands) {
return saveUpdateAndWaitForActivation(new
BulkUpdateProducer(List.copyOf(commands)));
}
+ /**
+ * Trim all catalog versions up to the given catalog (exclusively).
+ *
+ * @param catalog Earliest observable catalog.
+ * @return Operation future, which is completing with {@code true} if a
new snapshot has been successfully written, {@code false}
+ * otherwise if a snapshot with the same or greater version
already exists.
+ */
+ public CompletableFuture<Boolean> compactCatalog(Catalog catalog) {
Review Comment:
Done, replaced two methods `compactCatlog(long)` and
`compactCatalog(Catalog)` with single `compactCatalog(int)`.
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/ActiveTxMinimumStartTimeProvider.java:
##########
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.tx;
+
+import org.apache.ignite.internal.hlc.HybridTimestamp;
+import org.jetbrains.annotations.Nullable;
+
+/**
+ * Provides the minimum starting time among all locally started active RW
transactions.
Review Comment:
Done, thanks for the suggestion
(also renamed this class similarly)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
