xtern commented on code in PR #4137:
URL: https://github.com/apache/ignite-3/pull/4137#discussion_r1698727936
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogManagerImpl.java:
##########
@@ -342,17 +342,26 @@ public CompletableFuture<Integer>
execute(List<CatalogCommand> commands) {
return saveUpdateAndWaitForActivation(new
BulkUpdateProducer(List.copyOf(commands)));
}
+ /**
+ * Trim all catalog versions up to the given catalog (exclusively).
+ *
+ * @param catalog Earliest observable catalog.
+ * @return Operation future, which is completing with {@code true} if a
new snapshot has been successfully written, {@code false}
+ * otherwise if a snapshot with the same or greater version
already exists.
+ */
+ public CompletableFuture<Boolean> compactCatalog(Catalog catalog) {
Review Comment:
Done, replaced methods `compactCatlog(long)` and `compactCatalog(Catalog)`
with single `compactCatalog(int)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
