Cyrill commented on code in PR #4005:
URL: https://github.com/apache/ignite-3/pull/4005#discussion_r1707041005
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java:
##########
@@ -855,6 +862,8 @@ private RaftGroupOptions groupOptionsForPartition(boolean
isVolatileStorage, Sna
raftGroupOptions.commandsMarshaller(raftCommandsMarshaller);
+ partitionRaftConfigurator.configure(raftGroupOptions);
Review Comment:
added a todo
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/Loza.java:
##########
@@ -314,25 +325,29 @@ public <T extends RaftGroupService> CompletableFuture<T>
startRaftGroupNodeAndWa
RaftGroupListener lsnr,
RaftGroupEventsListener eventsLsnr,
RaftNodeDisruptorConfiguration disruptorConfiguration,
- @Nullable RaftServiceFactory<T> factory
+ @Nullable RaftServiceFactory<T> factory,
+ RaftOptionsConfigurator storageConfigurator
) throws NodeStoppingException {
if (!busyLock.enterBusy()) {
throw new NodeStoppingException();
}
try {
- CompletableFuture<T> startRaftServiceFuture =
startRaftGroupNodeInternal(
+ RaftGroupOptions raftGroupOptions = RaftGroupOptions.defaults();
+
+ storageConfigurator.configure(raftGroupOptions);
+
+
raftGroupOptions.ownFsmCallerExecutorDisruptorConfig(disruptorConfiguration);
Review Comment:
added a todo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
