Cyrill commented on code in PR #4005:
URL: https://github.com/apache/ignite-3/pull/4005#discussion_r1713315860
##########
modules/runner/src/main/java/org/apache/ignite/internal/configuration/IgnitePaths.java:
##########
@@ -68,21 +67,29 @@ public Path raftLogPath() {
}
/**
- * Path to Metastorage store.
+ * Get paths where metastorage data is stored.
Review Comment:
Fixed. Thanks.
##########
modules/runner/src/main/java/org/apache/ignite/internal/configuration/IgnitePaths.java:
##########
@@ -41,19 +41,18 @@ public class IgnitePaths {
/**
* Path to the persistent storage used by the MetaStorageManager component.
*/
- private static final Path METASTORAGE_DB_PATH = Paths.get("metastorage");
+ private static final Path METASTORAGE_PATH = Paths.get("metastorage");
/**
* Path to the persistent storage used by the
ClusterManagementGroupManager component.
*/
- private static final Path CMG_DB_PATH = Paths.get("cmg");
+ private static final Path CMG_PATH = Paths.get("cmg");
/**
- * Directory where partition data is stored. By default "partitions"
subfolder of data storage path is used.
+ * Get paths where partition data is stored.
Review Comment:
Fixed. Thanks.
##########
modules/runner/src/main/java/org/apache/ignite/internal/configuration/IgnitePaths.java:
##########
@@ -68,21 +67,29 @@ public Path raftLogPath() {
}
/**
- * Path to Metastorage store.
+ * Get paths where metastorage data is stored.
*
- * @param workDir Ignite working dir.
+ * @param systemConfiguration System configuration.
+ * @param workDir Node's working dir.
+ * @return Working dir subtree structure representation for metastorage.
*/
- public static Path metastorageDbPath(Path workDir) {
- return workDir.resolve(METASTORAGE_DB_PATH);
+ public static ComponentWorkingDir metastoragePath(SystemLocalConfiguration
systemConfiguration, Path workDir) {
+ Path basePath = pathOrDefault(systemConfiguration.metastoragePath(),
() -> workDir.resolve(METASTORAGE_PATH));
+
+ return new ComponentWorkingDir(basePath);
}
/**
- * Path to CMG store.
+ * Get paths where CMG data is stored.
Review Comment:
Fixed. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
