sashapolo commented on code in PR #4214:
URL: https://github.com/apache/ignite-3/pull/4214#discussion_r1713320195
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/RaftGroupServiceImpl.java:
##########
@@ -598,6 +597,8 @@ private void handleThrowable(
long stopTime,
CompletableFuture<? extends NetworkMessage> fut
) {
+ err = unwrapCause(err);
Review Comment:
> Am I right that you will always exclude
Yes, these exceptions are not very useful, they just always indicate that
you failed inside `sendWithRetry`.
> however it's definitely beyond the task description
This is not true to some extension, without this unwrapping, the
`PeerUnavailableException` will also be wrapped in `CompeltionException`. I
really don't want to add unwrapping just for this particular case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
