sashapolo commented on code in PR #4214:
URL: https://github.com/apache/ignite-3/pull/4214#discussion_r1713320422
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/RaftGroupServiceImpl.java:
##########
@@ -713,11 +714,9 @@ private void scheduleRetry(Runnable runnable) {
* @return {@code True} if this is a recoverable exception.
*/
private static boolean recoverable(Throwable t) {
- if (t instanceof ExecutionException || t instanceof
CompletionException) {
- t = t.getCause();
- }
+ t = unwrapCause(t);
Review Comment:
yes, just in case
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/RaftGroupServiceImpl.java:
##########
@@ -811,9 +810,20 @@ private CompletableFuture<ClusterNode> resolvePeer(Peer
peer) {
ClusterNode node =
cluster.topologyService().getByConsistentId(peer.consistentId());
if (node == null) {
- return CompletableFuture.failedFuture(new ConnectException("Peer "
+ peer.consistentId() + " is unavailable"));
+ return CompletableFuture.failedFuture(new
PeerUnavailableException("Peer " + peer.consistentId() + " is unavailable"));
Review Comment:
> BWT is a bit funny that ConnectionException wasn't handled.
It was, `ConnectException` is an `IOException`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
