sashapolo commented on code in PR #4214:
URL: https://github.com/apache/ignite-3/pull/4214#discussion_r1713338546
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/RaftGroupServiceImpl.java:
##########
@@ -811,9 +810,20 @@ private CompletableFuture<ClusterNode> resolvePeer(Peer
peer) {
ClusterNode node =
cluster.topologyService().getByConsistentId(peer.consistentId());
if (node == null) {
- return CompletableFuture.failedFuture(new ConnectException("Peer "
+ peer.consistentId() + " is unavailable"));
+ return CompletableFuture.failedFuture(new
PeerUnavailableException("Peer " + peer.consistentId() + " is unavailable"));
Review Comment:
> There are at least two placed where we still use ConnectException:
The first place that you mentioned (`RaftGroupServiceTest`) is a test where
we mock the `ClusterService` behavior, I think that using a `ConnectException`
is the correct choice there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
