xtern commented on code in PR #4240:
URL: https://github.com/apache/ignite-3/pull/4240#discussion_r1724630156
##########
modules/catalog-compaction/src/main/java/org/apache/ignite/internal/catalog/compaction/CatalogCompactionRunner.java:
##########
@@ -290,12 +321,20 @@ private CompletableFuture<Void>
startCompaction(LogicalTopologySnapshot topology
});
}
- CompletableFuture<Void> propagateToReplicasFut =
+ CompletableFuture<Boolean> propagateToReplicasFut =
propagateTimeToReplicas(minActiveTxBeginTime,
topologySnapshot.nodes())
- .whenComplete((res, ex) -> {
+ .whenComplete((success, ex) -> {
if (ex != null) {
LOG.warn("Failed to propagate
minimum active tx begin time to replicas", ex);
}
+
+ if (!success) {
+ LOG.info("Propagation of minimum
required time to replicas "
Review Comment:
Done, thanks.
##########
modules/catalog-compaction/src/test/java/org/apache/ignite/internal/catalog/compaction/CatalogCompactionRunnerSelfTest.java:
##########
@@ -545,4 +586,46 @@ private CatalogCompactionRunner createRunner(
return runner;
}
+
+ static class DummyTestPrimaryAffinity implements IntFunction<LogicalNode> {
Review Comment:
Done, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
