xtern commented on code in PR #4240:
URL: https://github.com/apache/ignite-3/pull/4240#discussion_r1726347654
##########
modules/catalog-compaction/src/main/java/org/apache/ignite/internal/catalog/compaction/message/CatalogCompactionMessageGroup.java:
##########
@@ -31,4 +31,8 @@ public class CatalogCompactionMessageGroup {
/** See {@link CatalogCompactionMinimumTimesResponse} for the details. */
public static final short MINIMUM_TIMES_RESPONSE = 1;
+
+ public static final short PREPARE_TO_UPDATE_TIME_ON_REPLICAS_REQUEST = 2;
Review Comment:
:sweat_smile: Fixed, thanks
##########
modules/catalog-compaction/src/main/java/org/apache/ignite/internal/catalog/compaction/message/CatalogCompactionPrepareUpdateTxBeginTimeResponse.java:
##########
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.catalog.compaction.message;
+
+import org.apache.ignite.internal.network.NetworkMessage;
+import org.apache.ignite.internal.network.annotations.Transferable;
+import org.jetbrains.annotations.Nullable;
+
+/**
+ * Result of tx time propagation to replicas.
+ *
+ * @see CatalogCompactionPrepareUpdateTxBeginTimeRequest
+ */
+@Transferable(CatalogCompactionMessageGroup.PREPARE_TO_UPDATE_TIME_ON_REPLICAS_RESPONSE)
+public interface CatalogCompactionPrepareUpdateTxBeginTimeResponse extends
NetworkMessage {
Review Comment:
Thanks, response message was removed
##########
modules/catalog-compaction/src/main/java/org/apache/ignite/internal/catalog/compaction/CatalogCompactionRunner.java:
##########
@@ -194,6 +200,31 @@ public CompletableFuture<Void> startAsync(ComponentContext
componentContext) {
return;
}
+ if (message.messageType() ==
CatalogCompactionMessageGroup.PREPARE_TO_UPDATE_TIME_ON_REPLICAS_REQUEST) {
Review Comment:
Done, thanks. Message handling moved to inner class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
