xtern commented on code in PR #4240:
URL: https://github.com/apache/ignite-3/pull/4240#discussion_r1726348351
##########
modules/catalog-compaction/src/main/java/org/apache/ignite/internal/catalog/compaction/CatalogCompactionRunner.java:
##########
@@ -401,74 +441,95 @@ private static List<String> missingNodes(Set<String>
requiredNodes, Collection<L
return
requiredNodes.stream().filter(not(logicalNodeIds::contains)).collect(Collectors.toList());
}
- CompletableFuture<Void> propagateTimeToReplicas(long timestamp,
Collection<? extends ClusterNode> topologyNodes) {
+ CompletableFuture<Boolean> propagateTimeToReplicas(long timestamp,
Collection<? extends ClusterNode> nodes) {
Review Comment:
Thanks, method renamed
`propagateTimeToReplicas` => `propagateTimeToNodes`
Suggest a better name if you have ideas.
##########
modules/catalog-compaction/src/main/java/org/apache/ignite/internal/catalog/compaction/CatalogCompactionRunner.java:
##########
@@ -401,74 +441,95 @@ private static List<String> missingNodes(Set<String>
requiredNodes, Collection<L
return
requiredNodes.stream().filter(not(logicalNodeIds::contains)).collect(Collectors.toList());
}
- CompletableFuture<Void> propagateTimeToReplicas(long timestamp,
Collection<? extends ClusterNode> topologyNodes) {
+ CompletableFuture<Boolean> propagateTimeToReplicas(long timestamp,
Collection<? extends ClusterNode> nodes) {
+ CatalogCompactionPrepareUpdateTxBeginTimeRequest request =
COMPACTION_MESSAGES_FACTORY
+ .catalogCompactionPrepareUpdateTxBeginTimeRequest()
+ .timestamp(timestamp)
+ .build();
+
+ List<CompletableFuture<?>> responseFutures = new
ArrayList<>(nodes.size());
+ AtomicBoolean successFlag = new AtomicBoolean(true);
Review Comment:
This flag was used to print the status of the operation (skipped, error,
success) in the log on the initiator node.
Anyway this code simplified, response removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
