tkalkirill commented on code in PR #4437:
URL: https://github.com/apache/ignite-3/pull/4437#discussion_r1773118877
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PageStoreWriter.java:
##########
@@ -18,22 +18,20 @@
package org.apache.ignite.internal.pagememory.persistence;
import java.nio.ByteBuffer;
-import java.util.concurrent.CompletableFuture;
import org.apache.ignite.internal.lang.IgniteInternalCheckedException;
import org.apache.ignite.internal.pagememory.FullPageId;
import org.apache.ignite.internal.pagememory.persistence.store.PageStore;
-/**
- * Interface for write page to {@link PageStore}.
- */
+/** Interface for IO writing dirty pages in {@link PageStore} on checkpoint. */
public interface PageStoreWriter {
/**
- * Callback for write page. {@link PersistentPageMemory} will copy page
content to buffer before call.
+ * Writes page to {@link PageStore}. {@link PersistentPageMemory} will
copy page content to buffer before call.
*
* @param fullPageId Page ID to get byte buffer for. The page ID must be
present in the collection returned by the {@link
- * PersistentPageMemory#beginCheckpoint(CompletableFuture)} method call.
+ * PersistentPageMemory#beginCheckpoint} method call.
Review Comment:
`PersistentPageMemory#beginCheckpoint` no longer apply the future, what do
you advise to do? leave it as is, don't fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
