tkalkirill commented on code in PR #4437:
URL: https://github.com/apache/ignite-3/pull/4437#discussion_r1773121177
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PersistentPageMemory.java:
##########
@@ -587,10 +587,9 @@ public long allocatePageNoReuse(int grpId, int partId,
byte flags) throws Ignite
throw e;
} finally {
seg.writeLock().unlock();
- }
- // Finish replacement only when an exception wasn't thrown otherwise
it possible to corrupt B+Tree.
Review Comment:
I don't think so, because now even if an exception is thrown, we will end up
replacing the page to finish the checkpoint if possible.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
