vldpyatkov commented on code in PR #5146:
URL: https://github.com/apache/ignite-3/pull/5146#discussion_r1937588845


##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/views/TransactionsViewProvider.java:
##########
@@ -108,6 +109,7 @@ public Iterator<TxInfo> iterator() {
                     new TransformingIterator<>(roTxIds.iterator(), 
TxInfo::readOnly),
                     rwTxStates.entrySet().stream()
                             .filter(e -> 
localNodeId.equals(e.getValue().txCoordinatorId())
+                                    && e.getValue().tx() != null && 
!e.getValue().tx().isReadOnly()

Review Comment:
   Of course, we can skip ` localNodeId.equals(e.getValue().txCoordinatorId())` 
checking and also use `rwTxStates` for both transaction types. But I left the 
logic as is because it takes additional changes that are not related for this 
PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to