Cyrill commented on code in PR #5146:
URL: https://github.com/apache/ignite-3/pull/5146#discussion_r1939060612
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/InternalTransaction.java:
##########
@@ -130,4 +130,11 @@ public interface InternalTransaction extends Transaction {
* @return The transaction timeout.
*/
long timeout();
+
+ /**
+ * Kills this transaction.
+ *
+ * @return The future.
+ */
+ CompletableFuture<Void> kill();
Review Comment:
`Transaction` comes with pairs of methods for transaction finish: `commit`
and `commitAsync`, `rollback` and `rollbackAsync`. The first one is a
synchronous method that returns void and the second one returns a future.
This method does not follow the common pattern. WDYT on this? Shall we name
it `killAsync`? What about a synchronous twin method `void kill()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
