Cyrill commented on code in PR #5146:
URL: https://github.com/apache/ignite-3/pull/5146#discussion_r1939071317
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/ReadWriteTransactionImpl.java:
##########
@@ -159,18 +162,54 @@ public CompletableFuture<Void> finish(boolean commit,
@Nullable HybridTimestamp
return finishFuture;
}
+ return finishInternal(commit, executionTimestamp, full, true);
+ }
+
+ private CompletableFuture<Void> finishInternal(
+ boolean commit,
+ @Nullable HybridTimestamp executionTimestamp,
+ boolean full,
+ boolean isComplete
Review Comment:
please add javadocs for these parameters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
